Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(core): change from deprecated renderer to renderer2 #19920

Closed
wants to merge 1 commit into from
Closed

docs(core): change from deprecated renderer to renderer2 #19920

wants to merge 1 commit into from

Conversation

Epenance
Copy link

@Epenance Epenance commented Oct 25, 2017 •
edited

We now show the proper class instead of the deprecated Renderer

Fixes #19806 (link)

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

ElementRef Documentation links to deprecated Renderer class

Issue Number: 19806

What is the new behavior?

It now links to Renderer2 class instead of the deprecated Renderer class

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@Epenance
Copy link
Author

Added alternate email to google account

@googlebot
Copy link

CLAs look good, thanks!

@Epenance
Copy link
Author

Linting and tests seem to fail unrelated to my changes, is there anything i should be doing?

@gkalpak
Copy link
Member

gkalpak commented Oct 25, 2017

The tests where flakes and the linting errors are indeed not related to this PR.
Can you please squash the two commits together. Then it should be good to go.

@gkalpak gkalpak added area: core Issues related to the framework runtime action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews target: patch This PR is targeted for the next patch release type: docs labels Oct 25, 2017
docs(core): change from deprecated renderer to renderer2
bf81d04 
We now show the proper class instead of the deprecated Renderer

Fixes angular#19806
@Epenance
Copy link
Author

@gkalpak Done :)

@mary-poppins
Copy link

You can preview f944085 at https://pr19920-f944085.ngbuilds.io/.
You can preview 1b2dade at https://pr19920-1b2dade.ngbuilds.io/.
You can preview d3cfae2 at https://pr19920-d3cfae2.ngbuilds.io/.
You can preview bf81d04 at https://pr19920-bf81d04.ngbuilds.io/.

@gkalpak gkalpak added action: review The PR is still awaiting reviews from at least one requested reviewer and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Oct 26, 2017
@gkalpak
Copy link
Member

gkalpak commented Oct 26, 2017

LGTM but someone from the core group has to approve it 😃

@jasonaden jasonaden mentioned this pull request Nov 11, 2017
Closed
@jasonaden jasonaden added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 11, 2017
jasonaden pushed a commit that referenced this pull request Nov 14, 2017
@jasonaden
docs(core): change from deprecated renderer to renderer2 (#19920)
91efc7f 
We now show the proper class instead of the deprecated Renderer

Fixes #19806


PR Close #19920
@jasonaden jasonaden closed this in 12af6d3 Nov 14, 2017
gkalpak added a commit to gkalpak/angular that referenced this pull request Nov 15, 2017
@gkalpak
style(core): fix max line length to pass linting
f4458fd 
Accidentally introduced in angular#19920, where other linting errors (unrelated to the
PR) prevented proper linting.
@gkalpak gkalpak mentioned this pull request Nov 15, 2017
Closed
jasonaden pushed a commit that referenced this pull request Nov 15, 2017
@gkalpak @jasonaden
style(core): fix max line length to pass linting (#20441)
259f6bf 
Accidentally introduced in #19920, where other linting errors (unrelated to the
PR) prevented proper linting.

PR Close #20441
jasonaden pushed a commit that referenced this pull request Nov 15, 2017
@gkalpak @jasonaden
style(core): fix max line length to pass linting (#20441)
c004d48 
Accidentally introduced in #19920, where other linting errors (unrelated to the
PR) prevented proper linting.

PR Close #20441
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chuckjaz chuckjaz chuckjaz approved these changes

@gkalpak gkalpak gkalpak approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker aio: preview area: core Issues related to the framework runtime cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ElementRef Documentation links to deprecated Renderer class
6 participants
@Epenance @googlebot @gkalpak @mary-poppins @chuckjaz @jasonaden